-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to choose template #269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4b6ski
force-pushed
the
template-flag
branch
from
December 8, 2024 21:58
89e1fc1
to
ba4145a
Compare
This change allows providing a custom template arg flag -t/--template: ``` sinol-make init foo -t [repo link or disk path] [optional subdir] ``` It defaults to the upstream repository and example_package subdir. Changed the example_package id pattern from `abc` to `__ID__`. All filenames and file contents are now substituted. Changed the positional output directory argument to `-o/--output` flag to help avoid accidents. Added result directory cleanup on failure.
j4b6ski
force-pushed
the
template-flag
branch
from
December 8, 2024 22:06
ba4145a
to
48a9028
Compare
MasloMaslane
requested changes
Dec 8, 2024
MasloMaslane
requested changes
Dec 9, 2024
Try accessing the local git repo in the project root first when cloning example_package. Only if that doesn't work, fall back to online github. Also adds some extra local path tests to init/test_unit. Also removes one unnecessary os.getcwd() call. Also removes the old "abc" template string hack since we test the current template now.
MasloMaslane
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows providing a custom template arg flag -t/--template:
It defaults to the upstream repository and example_package subdir.
Changed the example_package id pattern from
abc
to__ID__
. All filenames and file contents are now substituted.Changed the positional output directory argument to
-o/--output
flag to help avoid accidents.Added result directory cleanup on failure.